Modi's childhood mostly went to the Rampur State of Central Province where his father used to be the superintendent of the local Nawab. The library of Nawab Sahab was very prosperous, with Sohrab raised from the earliest childhood. There were many Urdu books in the library and Modi read books of Urdu after one. As a result, not only did his knowledge increase, but also the tongue became clear. In childhood, after mother's death at the age of three, her aunt raised him. In 1914, he got a matriculation degree from a new high school in Parel, Bombay.
He got his early education from Subhash Theatrical Company, a play company of his brother Rustom, in which he started working from 1924. At the same time, he learned the art of speaking dialogue in a serious and rude voice, which later became his speciality. After finishing his schooling, Modi became a Traveling Exhibitor with his brother. At the age of 16, he started performing various films in different areas of Gwalior through the Arya Subodh Theater Company. Later, with the help of his brother Rustam, he started the business of travel cinema. Then along with his brother, he established the stage film company in Bombay.
He made his acting debut from the film Khoon Ka Khoon in 1935, and even though he directed the film too. In the next year, he also made direction and even acting in the film Said-e-Havas starring Gulzar and Sadat Ali. From (1935-83), he appeared in a number of Hindi films such as Jailor, Pukar, Sikandar, Sheesh Mahal, Jhansi Ki Rani, Nausherwan-E-Adil, Jailor, Ek Nari Ek Brahmachari, and Razia Sultan was his last film as an actor. He directed his most of the films in which he worked as an actor. From (1935-69) he directed the Hindi films such as Atma Tarang, Khan Bahadur, Jailor, Pukar, Sikandar, Parakh, Ek Din Ka Sultan, Daulat, Jhansi Ki Rani, Kundan, Nausherwan-E-Adil, Mera Ghar Mere Bachche, and Samay Bada Balwan.He died on 28 January 1984 due to cancer of the bone marrow.